Open
Conversation
배송비 아이콘 업데이트 함수 for문 >>> forEach 변환 완료
카트 물품 가격 합계 구하는 함수 for문 >>> reduce 완료
전역변수 삭제 var >>> const 완료
set_tax_dom과 update_tax_dom의 이름을 봤을 때 분리할 필요가 없다고 생각하여 update_tax_down을 없애고 set_tax_down의 이름을 update_tax_down으로 변경 완료
calc_cart_total 함수는 가격의 합계를 구하는 역할만 해야하기 때문에 그 외의 함수들은 add_item_to_cart의 내부로 이동시킴 완료
Naming Rules snake >>> camelCase 완료
return 값이 있는 순수 함수 선언 방법 변경 function >>> arrow function 완료
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## 체크리스트
- [ O ] 코드 컨벤션을 준수했습니다
- [ O ] 불필요한 코드를 제거했습니다
- [ O ] 주석이 필요한 부분에 주석을 추가했습니다
## 질문사항
## 기타
### 본인이 작업할 때 사용한 Naming Rule | 코드 컨벤션을 작성해주세요.
Naming Rule
Code Convention