Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding update handler to dynamic sample #673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding update handler to dynamic sample #673

wants to merge 1 commit into from

Conversation

tsurdilo
Copy link
Contributor

@tsurdilo tsurdilo commented Sep 9, 2024

adds dynamic update handler and validator to DynamicSample

@tsurdilo tsurdilo requested review from antmendoza and a team as code owners September 9, 2024 19:52
Quinn-With-Two-Ns
Quinn-With-Two-Ns reviewed Sep 9, 2024
View reviewed changes
core/src/main/java/io/temporal/samples/hello/HelloDynamic.java
(signalName, encodedArgs) -> names.add(encodedArgs.get(0, String.class)));

// Register dynamic update handler
DynamicUpdateHandler updateHandler =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the DynamicUpdateHandler API here is flawed, we should change the API before adding a sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns left review comments

@antmendoza antmendoza Awaiting requested review from antmendoza antmendoza is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsurdilo @Quinn-With-Two-Ns