Skip to content

Conversation

@cretz
Copy link
Member

@cretz cretz commented Jan 7, 2026

What was changed

Remove grpc development dependency. This is needed in SDKs like Python because they test use of in-lang gRPC, but Ruby does not. And since Ruby 4 has been released but gRPC has not shipped binaries for it yet (coming next release), the entire gRPC C++ lib is built every time which is expensive. And it turns out we don't need the dep, so removing it.

But we do need googleapis-common-protos-types for testing since we import generated service files in tests that reference it (but we don't at runtime, and if a user does, it is them that can add the grpc dependency)

@cretz cretz marked this pull request as ready for review January 7, 2026 17:22
@cretz cretz requested a review from a team as a code owner January 7, 2026 17:22
@cretz cretz merged commit 457233b into temporalio:main Jan 7, 2026
7 checks passed
@cretz cretz deleted the remove-grpc-dep branch January 7, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants