fix: exclude dynamic templates from sitemap - #729
Closed
juandolealt wants to merge 2 commits into
Closed
juandolealt wants to merge 2 commits into
juandolealt wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
juandolealt
force-pushed
the
agent/exclude-blog-template-from-sitemap
branch
from
July 20, 2026 23:42
0d1d515 to
43f4a5d
Compare
Member
Author
|
Closing as superseded by #768 and #770. Current main already excludes bracketed dynamic route templates at generation time, preserves concrete blog and OpenAPI routes during sitemap finalization, and validates deployed sitemap coverage in CI. Verification against the resolved current-main tree covered 308 unit tests, type checking, a production build, generated-link and Markdown audits, and sitemap validation for 48 canonical API routes. The live sitemap currently contains 230 URLs, three concrete blog URLs, and no bracketed template URLs. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The live sitemap currently emits
/developers/blog/[slug], which resolves to a 404 and causes thetempo-webexternal sitemap check to fail. Filtering the template at the generator is more reliable than depending only on late post-processing.The latest
mainfinalizer also assumed every build emitsdist/public/sitemap.xml. E2E builds do not, so this PR handles the missing-file case without hiding other filesystem errors.Validation
CI=true pnpm buildVERCEL_ENV=production pnpm buildCI=true pnpm exec vitest run src/lib/sitemap.test.tspnpm exec biome check src/lib/sitemap.ts src/lib/sitemap.test.ts scripts/finalize-sitemap.ts vocs.config.ts