Conversation
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
hamdiallam
approved these changes
Oct 2, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validator docs never say where a firewall's validator IP list should come from. The natural guess,
ValidatorConfigV2.getActiveValidators(), returns the configured registry, not the committee consensus is using. Deactivated validators stay in the committee until a DKG ceremony removes them, and a failed DKG round keeps the previous committee in place, so a registry-only allowlist can block peers the node still needs.This adds:
tempo consensus info, which lists the DKG committee plus the active registry (the same peer set the node's peer manager tracks), and to refresh it continuously, since IP updates, new registrations, and identity rotations can land in any finalized block.Validation:
pnpm check:typespasses.Prompted by: @SuperFluffy