Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e780e701f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const relativePath = ref.link.slice("/sdk/typescript/".length); | ||
| const pagePath = join(pagesDir, "sdk", "typescript", `${relativePath}.mdx`); |
There was a problem hiding this comment.
Respect sdk-path-prefix when checking page paths
pageExists now slices links with a hard-coded "/sdk/typescript/" prefix, so the checker ignores the configured sdk-path-prefix input. In any workflow that sets a different prefix (for example the /docs/api case documented in this action’s README), valid sidebar links resolve to incorrect file paths and are reported as missing_page. This regresses the action’s advertised ability to run against other repo layouts.
Useful? React with 👍 / 👎.
Summary
mppx@295buildStore.AtomicStoreand synchronousStore.update()callback requirements across the Tempo server docsTesting