Skip to content

docs: verify AtomicStore follow-up#532

Open
brendanjryan wants to merge 2 commits intomainfrom
docs/atomic-store-followup
Open

docs: verify AtomicStore follow-up#532
brendanjryan wants to merge 2 commits intomainfrom
docs/atomic-store-followup

Conversation

@brendanjryan
Copy link
Copy Markdown
Collaborator

Summary

  • bump the docs workspace to the AtomicStore-enabled mppx@295 build
  • document Store.AtomicStore and synchronous Store.update() callback requirements across the Tempo server docs
  • repair the SDK drift checker so it validates this repo's conceptual SDK routes and current sidebar entrypoints

Testing

  • pnpm check:types
  • pnpm build
  • pnpm test -- .github/actions/sdk-drift-check/check-sdk-drift.test.ts
  • pnpm dlx tsx .github/actions/sdk-drift-check/check-sdk-drift.ts

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mpp Ready Ready Preview, Comment Apr 6, 2026 8:46pm

Request Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e780e701f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +393 to +394
const relativePath = ref.link.slice("/sdk/typescript/".length);
const pagePath = join(pagesDir, "sdk", "typescript", `${relativePath}.mdx`);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Respect sdk-path-prefix when checking page paths

pageExists now slices links with a hard-coded "/sdk/typescript/" prefix, so the checker ignores the configured sdk-path-prefix input. In any workflow that sets a different prefix (for example the /docs/api case documented in this action’s README), valid sidebar links resolve to incorrect file paths and are reported as missing_page. This regresses the action’s advertised ability to run against other repo layouts.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant