Fix blocking std::thread::sleep in async runtime#23
Merged
emmajam merged 1 commit intotempoxyz:mainfrom Feb 17, 2026
Merged
Conversation
Member
|
this its negligible impact but good hygiene - will merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
wait_for_readinessis an async function but usedstd::thread::sleep, which blocks the Tokio runtime. Since this function is awaited frommain, blocking calls pause the entire async executor for 5 seconds on each retry.Fix:
Replaced
std::thread::sleepwithtokio::time::sleep(...).awaitand removed the blocking import and closure.Impact:
The function is now fully non-blocking and correctly cooperates with the async runtime. This prevents unnecessary executor blocking and improves overall responsiveness.