fix: when holders > 10k & query fails, show > 10,000#792
Merged
Conversation
Bundle Size Report
Chunk changes (>1KB)
Compared against main branch (baseline from 2/4/2026, 5:13:51 PM) |
Cloudflare Deployments
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a009f1c647
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment was marked as resolved.
This comment was marked as resolved.
o-az
changed the title
The tidx server silently caps query results at 10,000 rows and returns 422 for extremely large aggregation queries. Both cases caused the /tokens page to show incorrect holder counts: - pathUSD (422 error): showed '0' instead of '> 10,000' - USDC.e (10k row truncation): showed '3,260' from incomplete data Changes: - Catch 422 errors in fetchTokenHoldersCount and return capped count - Detect when raw transfer pair rows hit the 10k server ceiling and treat the result as capped instead of aggregating incomplete data - Add .catch() for fetchTokenTransferAggregate so a single failed query doesn't reject the entire per-token promise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tidx server silently caps query results at 10,000 rows and returns 422 for extremely large aggregation queries. Both cases caused the /tokens page to show incorrect holder counts:
Changes
fetchTokenHoldersCountand return capped count.catch()forfetchTokenTransferAggregateso a single failed query doesn't reject the entire per-token promisePermanent indexer fix tracked in tidx#152.