Skip to content

Fix inconsistent subtask numbering in contract verification TODO #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0x0v4 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix inconsistent subtask numbering in contract verification TODO #803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/contract-verification/TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@ The API response at `GET /v2/contract/:chainId/:address?fields=all` already read

`src/route.verify.ts` now accepts an optional `creationTransactionHash` in the request body (L127), fetches the transaction receipt via `client.getTransactionReceipt()` (L684–700), and stores `transactionHash`, `blockNumber`, `transactionIndex`, and `deployer` in the deployment row on both insert (L1022–1034) and update of existing deployments (L1003–1017).

#### ✅ 3. Update existing deployment path (`route.verify.ts`) — DONE
#### ✅ 2. Update existing deployment path (`route.verify.ts`) — DONE

When a deployment row already exists with `transactionHash === null`, `route.verify.ts` updates it with the metadata if `creationTransactionHash` was provided (L1003–1017).

#### ❌ 2. Populate on new verifications (`route.verify-legacy.ts`) — NOT DONE
#### ❌ 3. Populate on new verifications (`route.verify-legacy.ts`) — NOT DONE

`src/route.verify-legacy.ts` still only inserts `chainId`, `address`, and `contractId` (L417–424). It does not accept `creationTransactionHash`, does not fetch deployment metadata, and does not update existing deployments that are missing metadata.

**To implement:** Mirror the approach from `route.verify.ts` — add `creationTransactionHash` to the request body, create a viem `publicClient`, fetch the receipt, and populate the deployment row.

#### ❌ 3. Backfill existing verified contracts — NOT DONE
#### ❌ 4. Backfill existing verified contracts — NOT DONE

No backfill script exists yet. A one-time script (e.g., `scripts/backfill-deployment-meta.ts`) is needed to:

Expand Down