fix(explorer): avoid holdings state updates during render#805
Open
umeeSthein wants to merge 1 commit intotempoxyz:mainfrom
Open
fix(explorer): avoid holdings state updates during render#805umeeSthein wants to merge 1 commit intotempoxyz:mainfrom
umeeSthein wants to merge 1 commit intotempoxyz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
### motivation
The holdings view in the address route was mutating local state during render.
It reset holdings pagination and the show-all toggle when the address changed, and it also clamped the current holdings page during render when the visible asset count shrank. That makes the route fragile and can cause unnecessary rerenders or pagination flicker when holdings data changes asynchronously.
### implications
- move holdings reset-on-address-change into
React.useEffect- move holdings page clamping into
React.useEffect- render address transitions with the default holdings UI state immediately
- reuse the normalized holdings page count for both row slicing and the holdings footer