Open
Conversation
Co-Authored-By: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4cfa-4f4f-715f-a0a8-6aa7bbf664cc
decofe
requested review from
0xKitsune,
SuperFluffy,
Zygimantass,
klkvr and
mattsse
as code owners
Co-authored-by: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4cfa-4f4f-715f-a0a8-6aa7bbf664cc
Tests that simulate pre-T1A/T1B/T1C environments by stripping fork times from test-genesis.json were not removing t4Time, so T4 stayed active and broke the pre-fork invariants. Co-Authored-By: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4cfa-4f4f-715f-a0a8-6aa7bbf664cc
Replaces manual removal of individual fork times with a single helper that walks TempoHardfork::VARIANTS and removes all forks after the given cutoff. New hardforks no longer require updating these tests. Co-Authored-By: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4cfa-4f4f-715f-a0a8-6aa7bbf664cc
Same pattern — t4Time wasn't disabled, so the node wasn't actually running pre-T1C. Co-Authored-By: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4cfa-4f4f-715f-a0a8-6aa7bbf664cc
Co-Authored-By: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4cfa-4f4f-715f-a0a8-6aa7bbf664cc
0xrusowsky
approved these changes
Apr 2, 2026
mattsse
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
T4variant toTempoHardforkenum,t4_timefield toTempoGenesisInfo,t4Timeto dev genesis and xtask genesis generator, and syncstempo.nuhardfork list (was also missing T3).also updates it tests to use a helper that auto-updates when new hardforks are created, rather than requiring manual additions for new variants
Prompted by: rusowsky