fix: include chains in /status when sync_state is empty#164
Merged
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
kamsz
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
/statusreturning an emptychainsarray when the API-visible database has nosync_staterows for configured chains.Before this change, the endpoint built
chainsexclusively fromsync_state, so it could returnok,version, andrevwhile omitting all configured chains. That showed up in production even though normal/queryrequests for both chain IDs still worked.This updates the handler to fall back to the configured pool map and emit a placeholder status entry for each configured chain when
sync_stateis empty or unavailable. That keeps the response shape stable and ensures/statusreflects configured chains instead of silently dropping them.Also adds a regression test covering the previously-missed case: empty
sync_state, configured chain still present in/status. Existing seeded-path/statusintegration coverage still passes.