Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go/common/viewingkey/viewing_key_signature.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type (
// CheckSignature checks if signature is valid for provided encryptionToken and chainID and return address or nil if not valid
func (psc PersonalSignChecker) CheckSignature(encryptionToken []byte, signature []byte, chainID int64) (*gethcommon.Address, error) {
if len(signature) != 65 {
return nil, fmt.Errorf("invalid signaure length: %d", len(signature))
return nil, fmt.Errorf("invalid signature length: %d", len(signature))
}
// We transform the V from 27/28 to 0/1. This same change is made in Geth internals, for legacy reasons to be able
// to recover the address: https://github.com/ethereum/go-ethereum/blob/55599ee95d4151a2502465e0afc7c47bd1acba77/internal/ethapi/api.go#L452-L459
Expand Down Expand Up @@ -53,7 +53,7 @@ func (psc PersonalSignChecker) CheckSignature(encryptionToken []byte, signature

func (e EIP712Checker) CheckSignature(encryptionToken []byte, signature []byte, chainID int64) (*gethcommon.Address, error) {
if len(signature) != 65 {
return nil, fmt.Errorf("invalid signaure length: %d", len(signature))
return nil, fmt.Errorf("invalid signature length: %d", len(signature))
}

msg, err := GenerateMessage(encryptionToken, chainID, 1, EIP712Signature)
Expand Down
2 changes: 1 addition & 1 deletion go/ethadapter/blob_beacon_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ func verifyBlobsMatchHashes(orderedSidecars []*BlobSidecar, hashes []gethcommon.
blobs := make([]*kzg4844.Blob, len(hashes))

// for fulu version, we should recompute the commitment from the blob
// for older vrsions we can just use the commitment from the API response directly
// for older versions we can just use the commitment from the API response directly
isFuluVersion := version == "fulu"

for i := range orderedSidecars {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ abstract contract ERC4626 is ERC20, IERC4626 {
* @dev Internal conversion function (from assets to shares) with support for rounding direction.
*
* Will revert if assets > 0, totalSupply > 0 and totalAssets = 0. That corresponds to a case where any asset
* would represent an infinite amout of shares.
* would represent an infinite amount of shares.
*/
function _convertToShares(uint256 assets, Math.Rounding rounding) internal view virtual returns (uint256 shares) {
uint256 supply = totalSupply();
Expand Down Expand Up @@ -182,7 +182,7 @@ abstract contract ERC4626 is ERC20, IERC4626 {
// calls the vault, which is assumed not malicious.
//
// Conclusion: we need to do the transfer before we mint so that any reentrancy would happen before the
// assets are transfered and before the shares are minted, which is a valid state.
// assets are transferred and before the shares are minted, which is a valid state.
// slither-disable-next-line reentrancy-no-eth
SafeERC20.safeTransferFrom(_asset, caller, address(this), assets);
_mint(receiver, shares);
Expand All @@ -209,7 +209,7 @@ abstract contract ERC4626 is ERC20, IERC4626 {
// calls the vault, which is assumed not malicious.
//
// Conclusion: we need to do the transfer after the burn so that any reentrancy would happen after the
// shares are burned and after the assets are transfered, which is a valid state.
// shares are burned and after the assets are transferred, which is a valid state.
_burn(owner, shares);
SafeERC20.safeTransfer(_asset, receiver, assets);

Expand Down
2 changes: 1 addition & 1 deletion integration/smartcontract/pk_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func TestRetrieve(t *testing.T) {
if !bytes.Equal(pubKeyABytes, recoveredPub) {
t.Errorf("unexpected pub keys. got: %s, expected: %s", recoveredPub, pubKeyABytes)
}
// recovered Pubkey yeilds the same address
// recovered Pubkey yields the same address
recoveredAddr := crypto.PubkeyToAddress(*recoveredPubKey)
if !bytes.Equal(addrA.Bytes(), recoveredAddr.Bytes()) {
t.Errorf("unexpected addresses Got %s, expected: %s", addrA.Hex(), recoveredAddr.Hex())
Expand Down
2 changes: 1 addition & 1 deletion lib/gethfork/node/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func (n *Node) apis() []rpc.API {
}

// adminAPI is the collection of administrative API methods exposed over
// both secure and unsecure RPC channels.
// both secure and insecure RPC channels.
type adminAPI struct {
node *Node // Node interfaced by this API
}
Expand Down
2 changes: 1 addition & 1 deletion tools/faucet/webserver/web_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func NewWebServer(faucetServer *faucet.Faucet, bindAddress string, jwtSecret []b
// authed endpoint
r.POST("/auth/fund/:token", jwtTokenChecker(jwtSecret, faucetServer.Logger), fundingHandler(faucetServer, defaultAmount))

// todo (@matt) we need to remove this unsecure endpoint before we provide a fully public sepolia faucet
// todo (@matt) we need to remove this insecure endpoint before we provide a fully public sepolia faucet
r.POST("/fund/:token", fundingHandler(faucetServer, defaultAmount))

r.GET("/balance", balanceReqHandler(faucetServer))
Expand Down