Skip to content

fix bug: not support lowercase keys in response header#34

Open
zhoumhh wants to merge 1 commit intotencentyun:masterfrom
zhoumhh:fixbug
Open

fix bug: not support lowercase keys in response header#34
zhoumhh wants to merge 1 commit intotencentyun:masterfrom
zhoumhh:fixbug

Conversation

@zhoumhh
Copy link

@zhoumhh zhoumhh commented Aug 2, 2019

void BaseResp::ParseFromHeaders(const std::map<std::string, std::string>& headers)

In this function, parameter headers is a map, keys in it maybe full lowercase in some environment, such as:

headers = {
    { "content-length": "5" },
    { "content-type": "text/plain" }
}

But variables (kReqHeader*) is defined by initial capitalization in "cos_params.h", such as:

const std::string kReqHeaderContentLen = "Content-Length";
const std::string kReqHeaderContentType = "Content-Type";

This function couldn't parse header correctly when response header is full lowercase!

The code added will find the value in map by lowercase key again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant