fix bug: not support lowercase keys in response header#34
Open
zhoumhh wants to merge 1 commit intotencentyun:masterfrom
Open
fix bug: not support lowercase keys in response header#34zhoumhh wants to merge 1 commit intotencentyun:masterfrom
zhoumhh wants to merge 1 commit intotencentyun:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
void BaseResp::ParseFromHeaders(const std::map<std::string, std::string>& headers)In this function, parameter
headersis a map, keys in it maybe full lowercase in some environment, such as:headers = { { "content-length": "5" }, { "content-type": "text/plain" } }But variables (kReqHeader*) is defined by initial capitalization in "cos_params.h", such as:
This function couldn't parse header correctly when response header is full lowercase!
The code added will find the value in map by lowercase key again.