Skip to content

Updating tensorflow_datasets/audio to remove pylint errors #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ManishAradwad
Copy link
Contributor

@ManishAradwad ManishAradwad commented Mar 15, 2020

Related with Issue #1644

I'm remaining with following errors:

groove.py:162:0: E0012: Bad option value 'g-complex-comprehension' (bad-option-value)
groove.py:31:0: E0401: Unable to import 'tensorflow.compat.v2' (import-error)
groove.py:82:8: C0103: Variable name "v2" doesn't conform to snake_case naming style (invalid-name)
groove.py:61:0: R0903: Too few public methods (0/2) (too-few-public-methods)
groove.py:156:70: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
groove.py:167:4: R0914: Too many local variables (24/15) (too-many-locals)
groove.py:207:16: C0103: Variable name "pm" doesn't conform to snake_case naming style (invalid-name)
groove.py:91:0: R0903: Too few public methods (0/2) (too-few-public-methods)

------------------------------------------------------------------
Your code has been rated at 8.24/10 (previous run: 8.24/10, +0.00)

Can somebody plz help me correct these?

@googlebot googlebot added the cla: yes Author has signed CLA label Mar 15, 2020
@ManishAradwad ManishAradwad changed the title Updated groove.py to remove pylint errors Updating tensorflow_datasets/audio to remove pylint errors Mar 15, 2020
@ChanchalKumarMaji
Copy link
Contributor

For eg., running the code below gives -

(tfds_env) chanchal@chanchal:~/datasets$ ./oss_scripts/lint.sh tensorflow_datasets/audio/
--2020-03-15 10:22:55--  https://raw.githubusercontent.com/tensorflow/tensorflow/master/tensorflow/tools/ci_build/pylintrc
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 199.232.20.133
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|199.232.20.133|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 11007 (11K) [text/plain]
Saving to: ‘/tmp/pylintrc’

/tmp/pylintrc                             100%[===================================================================================>]  10.75K  --.-KB/s    in 0.001s  

2020-03-15 10:22:56 (12.8 MB/s) - ‘/tmp/pylintrc’ saved [11007/11007]

Using config file /tmp/pylintrc
************* Module tensorflow_datasets.audio.libritts_test
C: 27, 0: Missing class docstring (missing-docstring)
************* Module tensorflow_datasets.audio.nsynth_test
W: 25, 2: Access to a protected member _SPLIT_SHARDS of a client class (protected-access)
************* Module tensorflow_datasets.audio.nsynth
C:144, 2: Missing method docstring (missing-docstring)
************* Module tensorflow_datasets.audio.librispeech_test
C: 27, 0: Missing class docstring (missing-docstring)
************* Module tensorflow_datasets.audio.libritts
C: 94, 2: Missing method docstring (missing-docstring)
************* Module tensorflow_datasets.audio.groove
C:119, 2: Missing method docstring (missing-docstring)
C:166, 2: Missing method docstring (missing-docstring)
************* Module tensorflow_datasets.audio.librispeech
C:163, 2: Missing method docstring (missing-docstring)
C:175, 2: Missing method docstring (missing-docstring)
************* Module tensorflow_datasets.audio.speech_commands
C:164, 0: Line too long (81/80) (line-too-long)
C:167, 2: Missing method docstring (missing-docstring)

-----------------------------------
Your code has been rated at 9.82/10

@tfds-bot tfds-bot added the community:is_reviewing This PR is being reviewed by community member. label Mar 15, 2020
@ManishAradwad ManishAradwad force-pushed the issue#1644 branch 2 times, most recently from 063232d to caec8e0 Compare March 15, 2020 06:34
@ManishAradwad
Copy link
Contributor Author

@ChanchalKumarMaji @Conchylicultor Can you plz review this PR?
I'm getting following output:
Your code has been rated at 10.00/10 (previous run: 9.95/10, +0.05)

@Conchylicultor Conchylicultor added the py3-migration Typing annotations label Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has signed CLA community:is_reviewing This PR is being reviewed by community member. py3-migration Typing annotations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants