Export protocol buffers #57
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peytondmurray
force-pushed
the
export-protocol-buffers
branch
from
fc4a452 to
08a80fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exports the original protocol buffers so that they can be used during the build steps of downstream packages. The protocol buffers are included as package data, so they now get shipped with the wheel.
Additionally, a new function has been added which gets the location of the protocol buffers so that downstream build systems can use them, akin to
numpy.get_include().It also adds a few other convenciences:
.bazelversionwhich targets the correct bazel version for this package.gitignoreto ignore generated python code