Angular Component Migration #6548
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
force-pushed
the
MigrateMatCheckbox
branch
4 times, most recently
from
8dcec64 to
7169a2f
Compare
JamesHollyer
force-pushed
the
MigrateMatCheckbox
branch
from
7169a2f to
b316347
Compare
JamesHollyer
force-pushed
the
MigrateMatCheckbox
branch
from
b316347 to
0b7f39b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
The legacy components are being deprecated. This is a big step in moving to the new components
Technical description of changes
This was done with a complicated find and replace which included manual pruning. After the find and replace the only other changes are in the mat-slider components as the new mat-sliders have a completely different structure with the thumb as a child component. This mat-slider change in the image card allowed for a cleanup of some weird logic.
Significantly I also change the mat.all-legacy-component-themes call to mat.all-component-themes in the _tb_theme.template.scss file.
This PR causes a lot of styling issues which will need to be resolved before syncing or releasing.
Screenshots of UI changes (or N/A)
Detailed steps to verify changes work correctly (as executed by you)
Alternate designs / implementations considered (or N/A)