[Clean-up] Clang-format some existing files #3179
Open
+90
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veblush
force-pushed
the
code-format
branch
from
3ec466f to
74e10e3
Compare
veblush
force-pushed
the
code-format
branch
from
74e10e3 to
d332bb8
Compare
ddavis-2015
reviewed
Sep 20, 2025
| @@ -120,7 +120,7 @@ enum MinMaxEvalType { kEvalMin, kEvalMax }; | |||
| template <typename T> | |||
| struct MinMaxReducerCompare { | |||
| MinMaxReducerCompare() = delete; | |||
| MinMaxReducerCompare(MinMaxEvalType evalType) : type_(evalType){}; | |||
| MinMaxReducerCompare(MinMaxEvalType evalType) : type_(evalType) {}; | |||
There was a problem hiding this comment.
I believe the Google style rules say that a space is not allowed between the parenthesis and the brace, and my IDE with it's auto formatting agrees. But the Pigweed style checker says that this is wrong and spacing must be there. I am much interested in your final resolution of this. This difference has only appeared in the last year or so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG=SImple-clean-up