Set Dynamo bind port with environment variable#4189
Draft
mjeremicTT wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
DYNAMO_BIND_PORTenvironment variable so the cpp_server's Dynamo generate endpoint can bind to a stable, predeclared TCP port instead of an OS-assigned one. Useful for k8s deployments where a sidecar, service or other deployment needs to know the port up front rather than discovering it after the fact.The change is fully backward compatible: when
DYNAMO_BIND_PORTis unset (or empty, or non-numeric), it falls back todefaults::DYNAMO_BIND_PORT = 0, which preserves today's behavior of letting the kernel pick a free ephemeral port. The resolved port is still advertised through discovery exactly as before, so frontends don't care which path was taken.