feat: Allows lookup of private hosted zones #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
private_zoneinput and passes along to the DNS zone lookup.Note that certificate validation and private_zone are mutually exclusive as AWS cert validation requires public DNS records. Something we do is create the private DNS zone and then create a public DNS entry for the validation but requires the private zone to be a subdomain of a public one.
Motivation and Context
Our sandbox account does not have a public DNS zone and we would like to use this module using our private DNS.
Breaking Changes
No
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestI do not believe there is a way I can add to the examples without expecting both a public and private DNS domain. I can add a variable for the private domain, but then it requires two domains. I can do so if desired.
As for testing this against something, we are currently using this for our API Gateway with a private DNS.