feat: Add support for websockets via appsync#77
Open
joshAtRula wants to merge 5 commits intoterraform-aws-modules:masterfrom
Open
feat: Add support for websockets via appsync#77joshAtRula wants to merge 5 commits intoterraform-aws-modules:masterfrom
joshAtRula wants to merge 5 commits intoterraform-aws-modules:masterfrom
Conversation
Member
|
this looks like a lot of AI generated garbage |
Author
|
@bryantbiggs AI was used to help make these improvements, yes, but hopefully there's some actual feedback and/or useful commentary you can provide (or someone else who can). This was tested and validated against actual resources, and was intentionally designed to adhere to the patterns in this repo. I'd be happy to address any concrete and actionable feedback you may have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support into the module for websocket/Events API by expanding the overall module in order to provide this other side of AppSync's capabilities.
Motivation and Context
AppSync supports the Events API for websockets with different channel namespaces that allow for different configurations and topics. These are managed at the edge (certs and domain registration exist as an extension of cloudfront, and therefore only in us-east-1) and handle scalable event pub/sub and integration with various routing resources.
Breaking Changes
This PR was intentionally designed to not break existing functionality, and reuse as much of the existing resources with conditionals as possible.
It was designed to reuse components, while adhering to the mutually exclusive invocation of appsync for events vs graphql. Because an appsync invocation cannot support both graphql and websockets/events, the module is built to deny those actions and will require separate invocations to deploy one of each.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestI have also exercised my fork of this module to deploy a websocket-based appsync in us-west-2 using this exact code for my organization.