Skip to content

security enforced #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

security enforced #476

wants to merge 1 commit into from
+172 −0

Conversation

rajatagarwal-ibm
Copy link
Member

Description

https://github.ibm.com/GoldenEye/issues/issues/14095

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@rajatagarwal-ibm rajatagarwal-ibm marked this pull request as ready for review June 4, 2025 14:53
@rajatagarwal-ibm
Copy link
Member Author

/run pipeline

@rajatagarwal-ibm rajatagarwal-ibm changed the title provider visibility security enforced Jun 4, 2025
ocofaigh
ocofaigh requested changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed - security enforced should be using security enforced variations for addons config

ibm_catalog.json
"dependencies": [
{
"name": "deploy-arch-ibm-account-infra-base",
"description": "Cloud automation for Account Configuration organizes your IBM Cloud account with a ready-made set of resource groups by default—and, when you enable the “with Account Settings” option, it also applies baseline security and governance settings.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"default—and" <-- needs to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocofaigh ocofaigh ocofaigh requested changes

@Ak-sky Ak-sky Awaiting requested review from Ak-sky Ak-sky is a code owner

@Aashiq-J Aashiq-J Awaiting requested review from Aashiq-J Aashiq-J is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajatagarwal-ibm @ocofaigh