-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to verify third-party plugin signature in private repositories #2209
Comments
Thank you for reporting this. This is due to plugin keyless verification introduced in v0.55. Can you share the artifact attestation of the plugin you have installed? |
@wata727 Here is the artifact attestation |
@wata727 Any update on the above issue ? |
After some research, it appears that attestations built in private repositories do not include transparency logs. Just like with GitHub CLI, we'll need to switch verification policies. |
It seems that we need GitHub Enterprise Cloud plan to test Artifact Attestations in private repositories. Supporting artifact attestations in private repositories can be difficult as we don't have sufficient funding to test the feature. |
It seems like it should be possible to verify them as long as the transparency log option is off in the verifier. This does make sense, it's a private repository, it can't be identified in transparency logs. I'm a GitHub Enterprise member so I can do one-time testing. We wouldn't have automated integration testing but it seems like the API difference is explicit enough that it won't be too hard to support. I would tend to agree that in practice external open source orgs are probably higher risk than internal compromises. But the sort of organization that wants to keep their plugins private is also more generally risk-averse and would want to defend against both. |
@bendrucker Thank you for your suggestion! Initially, I had a vision of forcing artifact attestations on all plugins, but given the plan limitations, I feel we need to have some kind of workaround for private plugins. If private plugins are always not verified, the verification behavior is always consistent without introducing an option like This side effect requires some thought, but I agree with you that providing the option to verify could certainly be beneficial for risk-averse organizations. How about releasing v0.55.1 with #2223 to always skip verification, and then in next versions (0.56+) supporting artifact attestation for private plugins? |
Yeah for sure, definitely patch it for the short term until we can test verification on a private repo. |
Summary
We have a in house plugin created to check for tags in resources so that is being installed as part of tflint init while performing the tflint --init we are getting the below error
14:28:05 signature.go:135: [DEBUG] Failed to verify signature: failed to verify log inclusion: not enough verified log entries from transparency log: 0 < 1
Failed to install a plugin; Failed to check checksums.txt signature: failed to verify log inclusion: not enough verified log entries from transparency log: 0 < 1
Command
tflint --init
Terraform Configuration
TFLint Configuration
Output
TFLint Version
0.55.0
Terraform Version
1.9.3
Operating System
The text was updated successfully, but these errors were encountered: