plugin: Skip keyless verification for private third-party plugins #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
wata727
force-pushed
the
skip_private_plugin_verify
branch
from
70689a3 to
f845d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2209
See also #2159
The keyless verification of plugins introduced in v0.55 is intended for public repositories and does not work properly for private repositories. Artifact attestations generated in private repositories do not include transparency logs, and the issuer of the certificate is GitHub, Inc, not sigstore.dev.
We can configure a policy to allow you to verify artifact attestations generated in private repositories by following the GitHub CLI, but given the plan limitations on the use of artifact attestations in private repositories, it may be difficult to enforce it in the future.
Given that the risk of plugin tampering in private repositories is lower than in public repositories, we thought it would be reasonable to skip verification in private repositories as a first step.
This PR changes the artifact attestation verification to be skipped if the source repository is private. In the future, artifact attestations for private repositories may be verified.