Adding configurable base layers, including adding wms options for moon and mars#13
Open
bedwards-ibm wants to merge 1 commit intomainfrom
Open
Adding configurable base layers, including adding wms options for moon and mars#13bedwards-ibm wants to merge 1 commit intomainfrom
bedwards-ibm wants to merge 1 commit intomainfrom
Conversation
bedwards-ibm
requested review from
bglar,
cwachira and
fredotieno
as code owners
bglar
reviewed
Mar 25, 2026
Comment on lines
+324
to
+333
| ## References | ||
|
|
||
| - **Implementation Plan**: `PLAN.md` | ||
| - **Configuration Guide**: `docs/BASE_LAYER_CONFIGURATION.md` | ||
| - **API Examples**: `docs/API_EXAMPLES.md` | ||
| - **Modified Code**: `app/js/components/inference/app-map.js` | ||
|
|
||
| ## Contact | ||
|
|
||
| For questions or issues related to this implementation, please refer to the documentation files or check the browser console for debugging information. No newline at end of file |
Contributor
There was a problem hiding this comment.
@bedwards-ibm we might need to clean up the info added to the docs like reference to files that aren't available (PLAN.md, docs/API_EXAMPLES.md)
Comment on lines
+216
to
+237
| ## Next Steps for Backend Team | ||
|
|
||
| 1. **Update Database Schema** (if needed) | ||
| ```sql | ||
| ALTER TABLE datasets ADD COLUMN base_layer VARCHAR(50) DEFAULT 'earth'; | ||
| ALTER TABLE layers ADD COLUMN base_layer VARCHAR(50) DEFAULT 'earth'; | ||
| ``` | ||
|
|
||
| 2. **Update API Responses** | ||
| - Include `baseLayer` in dataset GET responses | ||
| - Include `baseLayer` in layer GET responses | ||
| - See `docs/API_EXAMPLES.md` for detailed examples | ||
|
|
||
| 3. **Identify Existing Lunar/Mars Datasets** | ||
| - Review existing datasets | ||
| - Update `baseLayer` property for lunar datasets to `"moon"` | ||
| - Update `baseLayer` property for Mars datasets to `"mars"` | ||
|
|
||
| 4. **Test Integration** | ||
| - Load a lunar dataset in the UI | ||
| - Verify automatic switch to Moon base layer | ||
| - Check browser console for switching messages |
Contributor
There was a problem hiding this comment.
This section is on next steps for backend team, should we create some issues that the team needs to work on?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated PR message for Moon and Mars base layer implementation:
🌙 Add Moon and Mars Base Layers with Per-Layer Configuration
Summary
Implements support for Moon and Mars WMS base layers in the Cesium map viewer with automatic base layer switching based on per-layer configuration. Users can now visualize lunar and Martian datasets with appropriate celestial body imagery.
Features Added
1. New Celestial Body Base Layers
https://wms.im-ldi.com/, layer:luna_wac_global)https://wms.im-ldi.com/, layer:mars_viking_mdim2.1)Both layers are permanently visible in the Cesium base layer picker under "Celestial Bodies" category.
2. Per-Layer Base Layer Configuration
Introduced
baseLayerproperty for datasets and layers. Valid values:"earth"(default),"moon","mars","solar"(reserved)3. Automatic Base Layer Switching
System automatically switches to the appropriate base layer when loading datasets with
baseLayerproperty. Users can manually override at any time.Technical Implementation
Modified:
app/js/components/inference/app-map.js- Added WMS providers,switchBaseLayer()method, and automatic switching logicDocumentation:
docs/BASE_LAYER_CONFIGURATION.md,docs/API_EXAMPLES.md,docs/CELESTIAL_BODY_BASE_LAYERS_SUMMARY.md,PLAN.mdBackend Requirements
Backend APIs must include
baseLayerproperty in dataset and layer responses. Seedocs/API_EXAMPLES.mdfor examples and database migration guide.Known Limitations
Note: This PR includes unrelated additional info panel changes. Consider splitting into separate PRs if needed.