Fix some issues which were reported by Codacy #4266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Weil <[email protected]>
Apply also some smaller optimizations and add TODO comments for local variables which require further examination. Signed-off-by: Stefan Weil <[email protected]>
|
According to Codacy this pull request fixes about 32 issues (from a total of currently 590 issues), so much more work remains to be done. |
|
Is it possible to use auto in more places? |
egorpugin
approved these changes
Jun 11, 2024
| while (page_res_it.word() != nullptr && page_res_it.block() == current_block) { | ||
| current_row = page_res_it.row(); | ||
| ROW_RES *current_row = page_res_it.row(); |
| @@ -539,7 +533,7 @@ void Tesseract::tilde_delete(PAGE_RES_IT &page_res_it) { | |||
|
|
|||
| page_res_it.restart_page(); | |||
| while (page_res_it.word() != nullptr) { | |||
| word = page_res_it.word(); | |||
| WERD_RES *word = page_res_it.word(); | |||
| @@ -183,7 +182,7 @@ void Tesseract::fix_fuzzy_space_list(WERD_RES_LIST &best_perm, ROW *row, BLOCK * | |||
|
|
|||
| while ((best_score != PERFECT_WERDS) && !current_perm.empty()) { | |||
| match_current_words(current_perm, row, block); | |||
| current_score = eval_word_spacing(current_perm); | |||
| int16_t current_score = eval_word_spacing(current_perm); | |||
| WERD_RES *new_wd; | ||
|
|
||
| for (src_it.mark_cycle_pt(); !src_it.cycled_list(); src_it.forward()) { | ||
| src_wd = src_it.data(); | ||
| WERD_RES *src_wd = src_it.data(); |
Yes, sure, but sometimes I want to be able to see the data types explicitly for myself, and in other cases more work is needed to verify that Maybe some tools can |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.