Fix performance and other issues reported by Codacy #4309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stweil
commented
Aug 26, 2024
•
stweil
commented
- replace std::string::substr by std::string::resize
- initialize variables in initialization list
- fix several format strings
This fixes two performance issues reported by Codacy:
Ineffective call of function 'substr' because a prefix of the string
is assigned to itself. Use resize() or pop_back() instead.
Signed-off-by: Stefan Weil <[email protected]>
This fixes several performance issues reported by Coverity:
Variable 'master_trainer_' is assigned in constructor body.
Consider performing initialization in initialization list.
Signed-off-by: Stefan Weil <[email protected]>
This fixes five performance issues reported by Codacy:
%u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'.
%u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'.
%d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
Signed-off-by: Stefan Weil <[email protected]>
stweil
changed the title
egorpugin
approved these changes
Aug 26, 2024
|
I think it is possible to use in-class initializers instead of repeating vars in ctor. Instead of |
|
Also it is 2025 soon, I would propose to allow some c++20/23 features. What are tesseract compiler requirements? Support ubuntu20.04 lts gcc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.