Add C++ stream for log messages and use it in two debug messages #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Weil <[email protected]>
Optimize also the code a little bit. Signed-off-by: Stefan Weil <[email protected]>
Optimize also the code, replace tprintf by C++ stream and call clock() only when needed. Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
|
The sw builds failed. This is |
egorpugin
approved these changes
Sep 3, 2024
zdenop
reviewed
Sep 4, 2024
| tprintf("%s (ocr took %.2f sec)\n", word_data->word->best_choice->unichar_string().c_str(), | ||
| static_cast<double>(ocr_t - start_t) / CLOCKS_PER_SEC); | ||
| if (timing_debug) { | ||
| total_time = clock() - total_time; |
There was a problem hiding this comment.
Why now to use c++11 chrono::steady_clock::now() (https://en.cppreference.com/w/cpp/chrono/steady_clock - most suitable for measuring intervals) instead of std::clock()?
AFAIK it should be more platform consistent than `std::clock()'....
There was a problem hiding this comment.
We can use it any time, but in time critical code we'd have to check that it does not cost more resources than clock().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two debug message print execution times, previously in units of 0.01 seconds, now in milliseconds.
In function
ErrorCounter::ComputeErrorRatethe new code normally also avoids a call ofclock()which is only needed for the debug message.The new C++ stream
tesserrcan be used as an alternative totprintfwhich is type safe and avoids lots of type casts.