fix: quote script paths before handing them to a shell - #23
Merged
Merged
Conversation
Each test script was run as `bash #{file}` with the path interpolated raw. That
path is rooted at BUSSER_ROOT, which the caller chooses and Test Kitchen places
under a user-controlled directory, so a space anywhere in it split the command
and bash was handed a fragment instead of the script.
The command is now built by `command_for`, which escapes the path. The specs
assert on `Shellwords.split` -- what a shell would actually see -- so they check
the property rather than the escaping syntax.
Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: quote script paths before handing them to a shell
Each test script was run as
bash #{file}with the path interpolated raw. Thatpath is rooted at BUSSER_ROOT, which the caller chooses and Test Kitchen places
under a user-controlled directory, so a space anywhere in it split the command
and bash was handed a fragment instead of the script.
The command is now built by
command_for, which escapes the path. The specsassert on
Shellwords.split-- what a shell would actually see -- so they checkthe property rather than the escaping syntax.