Use new apache/kafka-native docker image for kafka module #2683
+47
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CTrando
commented
Aug 5, 2024
|
|
||
| // validateKRaftVersion validates if the image version is compatible with KRaft mode, | ||
| // which is available since version 7.0.0. | ||
| func validateKRaftVersion(fqName string) error { |
There was a problem hiding this comment.
every apache/kafka-native image supports kraft
CTrando
commented
Aug 5, 2024
|
|
||
| hostname := inspect.Config.Hostname | ||
|
|
||
| code, r, err := container.Exec(context.Background(), []string{"cat", "/usr/sbin/testcontainers_start.sh"}) |
There was a problem hiding this comment.
this script doesn't exist anymore in the kafka image - also I didn't think it was necessary to check advertisted listeners, considering if it's set incorrectly, the other tests would fail because kafka wouldn't work in the first place
CTrando
commented
Aug 5, 2024
| @@ -17,7 +15,7 @@ func TestKafka(t *testing.T) { | |||
|
|
|||
| ctx := context.Background() | |||
|
|
|||
| kafkaContainer, err := kafka.Run(ctx, "confluentinc/confluent-local:7.5.0", kafka.WithClusterID("kraftCluster")) | |||
| kafkaContainer, err := kafka.Run(ctx, "apache/kafka-native:3.8.0", kafka.WithClusterID("kraftCluster")) | |||
There was a problem hiding this comment.
TODO: need some more tests on the client side to demonstrate this works + add tests for setting host port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses the new apache/kafka-native docker image instead of the confluent local docker image. The kafka native docker image is much faster (startup time is maybe a second once the image is downloaded).
Trying to see if there is a desire from the community to use this. I can also add support for authentication mechanisms like SASL_PLAINTEXT if desired.
A current limitation of this however is that the desired host port must be known at container creation time - unlike before where we could dynamically pick a port at runtime. The way it was done before was a bit strange, it was running a kafka instance after the container had already started up I believe, which allowed it to pick the right port to use. Here, when we start up the kafka container it must know the port already.
We can still support picking random ports with some tricks like this, but there's no guarantee there won't be collisions.
Also I realize some of these changes may cause unavoidable breaking changes, so I'm happy to make a v2 module.
Why is it important?
Related issues