fix(mssql): bump Docker image version #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable all mssql tests as the container is currently crashing, see #2785
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The lint failure is handled by #2787 |
mdelapenya
changed the title
|
@stevenh I've updated the PR adding the changes proposed by @HofmeisterAn in the .NET project (thank you!) |
mdelapenya
reviewed
Sep 19, 2024
| @@ -128,25 +128,3 @@ func TestMSSQLServerWithInvalidPassword(t *testing.T) { | |||
| testcontainers.CleanupContainer(t, ctr) | |||
| require.NoError(t, err) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I'm removing this test because it's doing exactly the same as another one, using an image that at the moment has no alternative. We can remove, or skip, whatever you prefer.
|
Tests are passing again! https://github.com/testcontainers/testcontainers-go/actions/runs/10949418982/job/30403422765?pr=2786 |
|
@stevenh I'm merging this to unblock other PRs. PLMK anything you consider about this. We can discuss in a follow up PR. Thanks! |
mdelapenya
added a commit
that referenced
this pull request
Sep 20, 2024
* main: feat: support databend module (#2779) chore: golangci-lint 1.61.0 (#2787) fix(mssql): bump Docker image version (#2786) fix: handle 127 error code for podman compatibility (#2778) fix: do not override ImageBuildOptions.Labels when building from a Dockerfile (#2775) feat(mongodb): Wait for mongodb module with a replicaset to finish (#2777) fix(postgres): Apply default snapshot name if no name specified (#2783)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable all mssql tests as the container is currently crashing, see #2785This PR uses the MSSQL image that does not crash with the current update in the GH workers.
Related issues