Add getR2dbcUrl() to MariaDBR2DBCDatabaseContainer #11340
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a static helper method `getR2dbcUrl(MariaDBContainer)` to generate a valid R2DBC connection string. This simplifies configuration for R2DBC users. Relates to testcontainers#8797
eddumelendez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements the static
getR2dbcUrl()helper method for the MariaDB module, as discussed in #8797.This implementation follows the static method approach suggested by @eddumelendez in the issue comments (instead of adding it to the interface), ensuring discoverability without breaking changes.
Currently, users have to manually construct connection strings. This helper provides a standardized way to obtain a valid R2DBC URL.
Changes
public static String getR2dbcUrl(MariaDBContainer<?> container)toMariaDBR2DBCDatabaseContainer.Verification
./gradlew :testcontainers-mariadb:testand verified that tests pass.Relates to #8797