Skip to content

chore: Update pyproject and tests to support Mac's/arm local development #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

terry-docker
Copy link

@terry-docker terry-docker commented May 7, 2025

I want to help contribute to testcontainers-python but issues getting the local environment running. Starting off with fixing the install + test suite so myself and other people on Mac can get up and running faster.

Manual testing done:
This branch was tested on a few different Mac machines the and a Linux VM (still on arm). make install and make tests checked in all envs, I also checked docs, build, and cleans on the Linux VM and a M2 mac.

Notes:

  • Poetry markers aren't bullet proof, but works for ibm so it's good enough for now, else we'd need a more complex install and test build scripts (for dind tests) which I played around with but ended up removing to keep the PR smaller and less complex.
  • Skipping arm + mac specific tests in the test suite, these are testing either features that Macs don't have or the community module doesn't actually support macs. For the sake of contributors this shouldn't matter, the CI will still be testing everything fully.
  • Mac skip reasons given: I'm not deeply familiar with these community packages or the menewsha of mac docker vs other OS dockers. There might be better explanations for why it needed to be skipped.

Ticket:
#813

@terry-docker terry-docker force-pushed the support-arm-local-development branch from b1cf47a to 7c4d4c8 Compare May 7, 2025 21:19
ambitda
ambitda previously approved these changes May 7, 2025
@terry-docker terry-docker changed the title Update pyproject and tests to support Mac's/arm local development chore: Update pyproject and tests to support Mac's/arm local development May 7, 2025
@terry-docker terry-docker force-pushed the support-arm-local-development branch from f555efe to 7522fbf Compare May 8, 2025 15:57
@terry-docker terry-docker force-pushed the support-arm-local-development branch from 7522fbf to 28d7024 Compare May 8, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants