Skip to content

feat: make config monkeypatchable, fix config related startup issues #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CarliJoy
Copy link
Contributor

@CarliJoy CarliJoy commented Jun 17, 2025

Make configuration monkeypatchable.

Also show users how within readme.

This should also fix the bug in #830 and supersedes #821 and #832

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@632e5f4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
core/testcontainers/core/config.py 97.29% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #833   +/-   ##
=======================================
  Coverage        ?   85.71%           
=======================================
  Files           ?       13           
  Lines           ?      707           
  Branches        ?      115           
=======================================
  Hits            ?      606           
  Misses          ?       76           
  Partials        ?       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexanderankin alexanderankin changed the title feat: make config monkeypatchable feat: make config monkeypatchable, fix config related startup issues Jun 17, 2025
@alexanderankin alexanderankin merged commit ff6a32d into testcontainers:main Jun 23, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants