Skip to content

Conversation

@mschmitzer
Copy link
Contributor

Part of fixing #874.

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.78%. Comparing base (5c1504c) to head (3903509).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #899   +/-   ##
=======================================
  Coverage   79.78%   79.78%           
=======================================
  Files          14       14           
  Lines        1182     1182           
  Branches      184      184           
=======================================
  Hits          943      943           
  Misses        197      197           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mschmitzer mschmitzer force-pushed the minio-wait-strategy branch from 79bff0f to 3903509 Compare October 9, 2025 10:37
@artem-ilin
Copy link
Contributor

@mschmitzer I see this PR is good to go. And I saw you've already done a commit for redis container. Can you please create a PR for that too?

@mschmitzer
Copy link
Contributor Author

@mschmitzer I see this PR is good to go. And I saw you've already done a commit for redis container. Can you please create a PR for that too?

Glad to hear that 👍
I held back on the Redis MR to see how this one goes first. Created it now: #914

@mschmitzer
Copy link
Contributor Author

@artem-ilin Can we proceed with this and #914 ?

@artem-ilin
Copy link
Contributor

artem-ilin commented Dec 5, 2025

@mschmitzer hi! I'm not a maintainer, even not a contributor yet :)
But if the "merge" button is available for you - I believe you can press it and the same for the other PR.

On my side I am also waiting for a #915 to be approved (the same fix for Elasticsearch container)

UPD: to be honest I'm looking forward to your redis PR to be merged

@mschmitzer
Copy link
Contributor Author

Ah, I see. So I guess I should ping @alexanderankin 😄

@alexanderankin alexanderankin merged commit febccb7 into testcontainers:main Dec 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants