-
Notifications
You must be signed in to change notification settings - Fork 349
fix(minio): Use wait strategy instead of deprecated decorator #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
=======================================
Coverage 79.78% 79.78%
=======================================
Files 14 14
Lines 1182 1182
Branches 184 184
=======================================
Hits 943 943
Misses 197 197
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
79bff0f to
3903509
Compare
|
@mschmitzer I see this PR is good to go. And I saw you've already done a commit for redis container. Can you please create a PR for that too? |
Glad to hear that 👍 |
|
@artem-ilin Can we proceed with this and #914 ? |
|
@mschmitzer hi! I'm not a maintainer, even not a contributor yet :) On my side I am also waiting for a #915 to be approved (the same fix for Elasticsearch container) UPD: to be honest I'm looking forward to your redis PR to be merged |
|
Ah, I see. So I guess I should ping @alexanderankin 😄 |
Part of fixing #874.