-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support copy files to container #730
Conversation
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4714e8f
to
a8e6dab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there 👋
Thank you a lot for the contribution 👍
However it would be nice to rationalize the need and discuss the proposal before putting an effort 🙏
So, I guess mount
functionality doesn't cover your needs? You want a full independent copy of files, right? So we will have both mounting and copy features (like in Java version)
Hi, the rational behind is specially when using Docker In Docker environments with the docker-socket mounted. Here, copying files to the container instead of mounting them is way easier and less error prone. This is one of the main reasons why this is needed. |
I actually think it's a useful feature, so I don't mind for sure. That's why I prefer to have at least a short issue to have visibility |
Completely understandable. Next time, I'll raise an issue first for discussion. |
a8e6dab
to
e6d339f
Compare
e6d339f
to
3c908af
Compare
3c908af
to
4249029
Compare
Just to chime in quickly from a meta Testcontainers perspective: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution and patience during the review process ❤️
Thanks for all the help. I realy appreciate your effort. |
This PR supports copying files into the container like this: