chore: copy-to-container interface improvements #1152
GitHub Actions / clippy
succeeded
Sep 13, 2024 in 0s
clippy
3 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 3 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.81.0 (eeb90cda1 2024-09-04)
- cargo 1.81.0 (2dbb1af80 2024-08-20)
- clippy 0.1.81 (eeb90cd 2024-09-04)
Annotations
Check warning on line 47 in testcontainers/src/core/logs/consumer/logging_consumer.rs
github-actions / clippy
this manual char comparison can be written more succinctly
warning: this manual char comparison can be written more succinctly
--> testcontainers/src/core/logs/consumer/logging_consumer.rs:47:48
|
47 | let message = message.trim_end_matches(|c| c == '\n' || c == '\r');
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['\n', '\r']`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison
= note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default
Check warning on line 29 in testimages/build.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> testimages/build.rs:27:14
|
27 | .arg(&format!(
| ______________^
28 | | "{cwd}/src/dockerfiles/simple_web_server.dockerfile"
29 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
27 ~ .arg(format!(
28 + "{cwd}/src/dockerfiles/simple_web_server.dockerfile"
29 ~ ))
|
Check warning on line 12 in testimages/build.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> testimages/build.rs:12:14
|
12 | .arg(&format!("{cwd}/src/dockerfiles/no_expose_port.dockerfile"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{cwd}/src/dockerfiles/no_expose_port.dockerfile")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
Loading