Jovian upgrade for OP Stack by mininny · Pull Request #269 · testinprod-io/op-erigon

mininny · 2025-11-04T17:25:00Z

This PR prepares op-erigon v2 for jovian upgrade:

https://specs.optimism.io/protocol/jovian/exec-engine.html
corresponding op-geth PRs: https://github.com/ethereum-optimism/op-geth/pulls?q=label%3AH-jovian+is%3Apr
accompanying erigon interfaces PR: Add minbasefee to execution payload for jovian erigon-interfaces#24

…m-optimism/op-geth#671

…/github.com/ethereum-optimism/op-geth/pull/712/files

Copilot

Pull Request Overview

This PR implements support for the Optimism Jovian hardfork, which introduces several key features:

DA (Data Availability) footprint block limits stored in the BlobGasUsed header field
Minimum base fee enforcement via new extra data encoding
Updated precompile input size limits for cryptographic operations
Operator fee calculation fix (multiplying by 100)

Reviewed Changes

Copilot reviewed 45 out of 47 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
erigon-lib/chain/chain_config.go	Adds `JovianTime` field and fork detection methods `IsJovian()` and `IsOptimismJovian()`
consensus/misc/eip1559_optimism.go	New file implementing Jovian extra data encoding/decoding with minimum base fee support
consensus/misc/eip1559.go	Updates base fee calculation to use DA footprint and enforce minimum base fee
eth/stagedsync/stage_mining_*.go	Implements DA footprint calculation and enforcement during block building
core/vm/contracts.go	Adds Jovian-specific precompile contracts with updated input size limits
erigon-lib/opstack/rollup_cost.go	Adds operator fee fix calculation and DA footprint gas scalar extraction
core/types/receipt.go	Adds `DAFootprintGasScalar` and `BlobGasUsed` fields to receipts
turbo/jsonrpc/eth_receipts.go	Populates new receipt fields for Jovian blocks
params/protocol_params.go	Defines new Jovian precompile input size limits
erigon-lib/types/txn.go	Adds `EstimatedDASize()` method for transaction DA estimation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T17:33:53Z

consensus/misc/eip1559_optimism.go

+	}
+}
+
+// DecodeHolocene1559Params extracts the Holcene 1559 parameters from the encoded form defined here:


Corrected spelling of 'Holcene' to 'Holocene'.

Suggested change

// DecodeHolocene1559Params extracts the Holcene 1559 parameters from the encoded form defined here:

// DecodeHolocene1559Params extracts the Holocene 1559 parameters from the encoded form defined here:

Copilot · 2025-11-04T17:33:54Z

eth/stagedsync/stage_mining_finish.go

+		header.BlobGasUsed = &daFootprint
+	}
+
 	block := types.NewBlockForAsembling(current.Header, current.Txs, current.Uncles, current.Receipts, current.Withdrawals, cfg.chainConfig.IsOptimismIsthmus(current.Header.Time))


Corrected spelling of 'Asembling' to 'Assembling' in function name.

Suggested change

block := types.NewBlockForAsembling(current.Header, current.Txs, current.Uncles, current.Receipts, current.Withdrawals, cfg.chainConfig.IsOptimismIsthmus(current.Header.Time))

block := types.NewBlockForAssembling(current.Header, current.Txs, current.Uncles, current.Receipts, current.Withdrawals, cfg.chainConfig.IsOptimismIsthmus(current.Header.Time))

Copilot · 2025-11-04T17:33:54Z

eth/stagedsync/stage_mining_exec.go

 	signer := types.MakeSigner(&chainConfig, header.Number.Uint64(), header.Time)

+	// OP-Stack additions: throttling and DA footprint limit
+	//blockDABytes := new(big.Int)


The blockDABytes variable is declared and commented out on line 406, suggesting incomplete or planned work. If this variable is no longer needed, the comment should be removed. If it's for future use, add a TODO comment explaining the intent.

Suggested change

//blockDABytes := new(big.Int)

// TODO: track total DA bytes in blockDABytes for future DA footprint enforcement

Copilot · 2025-11-04T17:33:54Z

eth/stagedsync/stage_mining_exec.go

+		// OP-erigon isn't for sequencing
+		// OP-Stack addition: sequencer throttling
+		//daBytesAfter := new(big.Int)
+		//if txn.RollupCostData().EstimatedDASize() != nil && miner.config.MaxDABlockSize != nil {
+		//	daBytesAfter.Add(blockDABytes, ltx.DABytes)
+		//	if daBytesAfter.Cmp(miner.config.MaxDABlockSize) > 0 {
+		//		log.Debug("adding tx would exceed block DA size limit",
+		//			"hash", ltx.Hash, "txda", ltx.DABytes, "blockda", blockDABytes, "dalimit", miner.config.MaxDABlockSize)
+		//		txs.Pop()
+		//		// If the number of remaining bytes is too few to hold even the minimum possible transaction size,
+		//		// then we can stop early.
+		//		daBytesRemaining := new(big.Int).Sub(miner.config.MaxDABlockSize, daBytesAfter)
+		//		if daBytesRemaining.Cmp(types.MinTransactionSize) < 0 {
+		//			break
+		//		}
+		//		continue
+		//	}
+		//}


Large block of commented-out code (lines 521-538) should be removed if it's not needed, or converted to a proper TODO/FIXME comment if it represents future work. Commented-out code creates confusion about whether it should be preserved or removed.

Suggested change

// OP-erigon isn't for sequencing

// OP-Stack addition: sequencer throttling

//daBytesAfter := new(big.Int)

//if txn.RollupCostData().EstimatedDASize() != nil && miner.config.MaxDABlockSize != nil {

// daBytesAfter.Add(blockDABytes, ltx.DABytes)

// if daBytesAfter.Cmp(miner.config.MaxDABlockSize) > 0 {

// log.Debug("adding tx would exceed block DA size limit",

// "hash", ltx.Hash, "txda", ltx.DABytes, "blockda", blockDABytes, "dalimit", miner.config.MaxDABlockSize)

// txs.Pop()

// // If the number of remaining bytes is too few to hold even the minimum possible transaction size,

// // then we can stop early.

// daBytesRemaining := new(big.Int).Sub(miner.config.MaxDABlockSize, daBytesAfter)

// if daBytesRemaining.Cmp(types.MinTransactionSize) < 0 {

// break

// }

// continue

// }

//}

// TODO: Implement OP-Stack sequencer throttling and block DA size limit logic if needed.

Copilot · 2025-11-04T17:33:55Z

consensus/misc/eip1559_optimism.go

+// DecodeJovianExtraData decodes the extraData parameters from the encoded form defined here:
+// https://specs.optimism.io/protocol/jovian/exec-engine.html
+//
+// Returns 0,0,nil if the format is invalid, and d, e, nil for the Holocene length, to provide best effort behavior for non-Jovian extradata, though ValidateMinBaseFeeExtraData should be used instead of this function for


The comment references ValidateMinBaseFeeExtraData which doesn't exist in the codebase. It should reference ValidateJovianExtraData instead.

Suggested change

// Returns 0,0,nil if the format is invalid, and d, e, nil for the Holocene length, to provide best effort behavior for non-Jovian extradata, though ValidateMinBaseFeeExtraData should be used instead of this function for

// Returns 0,0,nil if the format is invalid, and d, e, nil for the Holocene length, to provide best effort behavior for non-Jovian extradata, though ValidateJovianExtraData should be used instead of this function for

Copilot · 2025-11-04T17:33:55Z

eth/stagedsync/stage_mining_create_block.go

+	if cfg.chainConfig.IsJovian(parent.Time) {
+		if len(cfg.blockBuilderParameters.Transactions) == 0 {
+			return errors.New("missing L1 attributes deposit transaction")
+		}
+		transaction, err := types.UnmarshalTransactionFromBinary(cfg.blockBuilderParameters.Transactions[0], false)
+		if err != nil || transaction.Type() != types.DepositTxType {
+			return errors.New("missing L1 attributes deposit transaction")
+		}
+		current.daFootprintGasScalar, err = opstack.ExtractDAFootprintGasScalar(transaction.GetData())
+		if err != nil {
+			return err
+		}
+	}


On line 251, the error from UnmarshalTransactionFromBinary is checked but then overwritten with a generic error message. The original error should be wrapped or included in the returned error for better debugging: return fmt.Errorf(\"missing L1 attributes deposit transaction: %w\", err).

mininny added 7 commits November 3, 2025 21:45

Add jovian timestamp flags

dea367f

jovian: make isthmus gas params extraction forward-compatible ethereu…

9180a2f

…m-optimism/op-geth#671

introduce minimum base fee ethereum-optimism/op-geth#666

21ca3ba

Implement DA footprint block limit for jovian

3d6d3c0

implement operator fee: ethereum-optimism/op-geth#696

fc1ef33

Add new precompile limits for Jovian: ethereum-optimism/op-geth#709

3b7e80f

Update supercfhain registry commit for new jovian timestamps: https:/…

054f8d7

…/github.com/ethereum-optimism/op-geth/pull/712/files

mininny requested review from ImTei and Copilot November 4, 2025 17:25

Copilot AI reviewed Nov 4, 2025

View reviewed changes

Fix MinBaseFee type and add jovian override flag

816896a

mininny force-pushed the feat/mininny/jovian branch 3 times, most recently from 1f74e90 to 66a0443 Compare November 10, 2025 15:34

Fix DAFootprint calculation in block header

7f37c73

mininny force-pushed the feat/mininny/jovian branch 4 times, most recently from 81aa237 to a047567 Compare November 12, 2025 06:35

Fix build errors

ed57b3c

mininny force-pushed the feat/mininny/jovian branch from a047567 to ed57b3c Compare November 12, 2025 06:36

mininny merged commit 4e385d8 into op-erigon Nov 12, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jovian upgrade for OP Stack#269

Jovian upgrade for OP Stack#269
mininny merged 10 commits intoop-erigonfrom
feat/mininny/jovian

mininny commented Nov 4, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Copilot AI Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// DecodeHolocene1559Params extracts the Holcene 1559 parameters from the encoded form defined here:
	// DecodeHolocene1559Params extracts the Holocene 1559 parameters from the encoded form defined here:

	block := types.NewBlockForAsembling(current.Header, current.Txs, current.Uncles, current.Receipts, current.Withdrawals, cfg.chainConfig.IsOptimismIsthmus(current.Header.Time))
	block := types.NewBlockForAssembling(current.Header, current.Txs, current.Uncles, current.Receipts, current.Withdrawals, cfg.chainConfig.IsOptimismIsthmus(current.Header.Time))

	//blockDABytes := new(big.Int)
	// TODO: track total DA bytes in blockDABytes for future DA footprint enforcement

	// Returns 0,0,nil if the format is invalid, and d, e, nil for the Holocene length, to provide best effort behavior for non-Jovian extradata, though ValidateMinBaseFeeExtraData should be used instead of this function for
	// Returns 0,0,nil if the format is invalid, and d, e, nil for the Holocene length, to provide best effort behavior for non-Jovian extradata, though ValidateJovianExtraData should be used instead of this function for

Conversation

mininny commented Nov 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants