Skip to content

Fix print time metrics not being cleared correctly#41

Open
hyperair wants to merge 2 commits intotg44:masterfrom
hyperair:fix-print-time-metrics-clearing
Open

Fix print time metrics not being cleared correctly#41
hyperair wants to merge 2 commits intotg44:masterfrom
hyperair:fix-print-time-metrics-clearing

Conversation

@hyperair
Copy link
Contributor

@hyperair hyperair commented Feb 5, 2024

This fixes an issue where print time metrics for a path that has completed don't get fully cleared after print completion

@hyperair hyperair mentioned this pull request Feb 5, 2024
@tg44 tg44 mentioned this pull request Feb 5, 2024
@arcnmx
Copy link

arcnmx commented Jul 14, 2024

Trying this seemed to result in an error after a cancel?

Exception in thread Thread-102:
TypeError: PrometheusExporterPlugin.print_deregister_callback() takes 2 positional arguments but 51 were given
Exception in thread Thread-106:
TypeError: PrometheusExporterPlugin.print_deregister_callback() missing 1 required positional argument: 'label'

Timer takes args as a single parameter, not *args
@hyperair
Copy link
Contributor Author

Oops, just fixed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants