Automatically choose next validator from propose queue #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgrospic
reviewed
Aug 19, 2022
| st.update(s => ({...s, nets, sel, devMode: enabled})) | ||
| } | ||
|
|
||
| const FetchNextValidator = async () => { |
Owner
There was a problem hiding this comment.
UI controls should not have direct dependency to http requests so this functions should be in rnode-web.js file and imported together with other effects.
| const sel = findValidatorByIndex(ev.target.selectedIndex) | ||
| const read = sel.name === valNode.name ? readNode : findReadOnlyByIndex(0, sel.name) | ||
| const isMainnet = sel.name === 'mainnet' | ||
| sel.name !== valNode.name ? onAutoSelectToggle({disabled: !isMainnet}) : undefined |
Owner
There was a problem hiding this comment.
This is not assignment so no need to explicitly set undefined value.
sel.name !== valNode.name && onAutoSelectToggle({disabled: !isMainnet})| wallet: [], // [{name: 'My REV account', ...newRevAddress()}], | ||
| // Dev mode (show local networks) | ||
| devMode, | ||
| autoSelectDisabled: autoSelectDisabled |
Owner
There was a problem hiding this comment.
Please use autoSelect as a positive meaning of the boolean field with the default false as disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that deploys get into a block faster (within 1 minutes rather than 15 minutes) by automatically choosing one of the next two validators from the propose queue by using this API https://status.rchain.coop/api/validators. Finalization still takes quite a bit of time so improvement may not be significant.
All that is required from the user is to switch to mainnet. Switching back to any other network pauses the autoselector.
When mainnet is enabled, Transfer and Deploy buttons are disabled during the first fetch, so that user doesn't use a manually selected node.
For convenience there is a checkbox to manually disable this behavior too.