Pull request #29
Open
Pull request #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated documentation to reflect current EquityOrder usage.
Added support for the preview flag in orders; allows you to preview an order prior to placing.
Added the fetch(...) and delete(...) methods to the EquityOrder object allowing users to fetch order info (e.g., checking status of open order) and to ability to delete equity orders.
Enabled live trading option for EquityOrder object.
tradier.py is a duplicate of legacy/tradier.py. It is not used in current version.
Updated README.md to fix some minor inconsistencies.
Added in modify function to the EquityOrder object. Allows users to modify existing orders.
Updated readme to include mention of the EquityOrder delete and modify methods. Additionally, changed the order(...) method example to show position arguments insteado of implying all arguments are optional.
quotes.py: Calling float(...) on a single element series is depreciated in pandas. Changed line 225 from `float(df_quote['last']);` to `float(df_quote['last'].iloc[0]);` setup.py: Changed version patch number to reflect the minor changes implemented.
|
Hey I just saw your pull request - thanks so much! I really appreciate it. I hadn't even realized that the EquityOrder class was missing the Thanks again for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I implemented some minor changes
eo.orderversuseo.equity_ordermodify(order_id, [order_type, duration, limit_price, stop_price])modifies an existing order.delete(order_id)deletes an existing orderfetch(order_id)fetches information about a specific order.live_trade=[True,False])