generated from the-collab-lab/smart-shopping-list
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to typescript #50
Draft
kweeuhree
wants to merge
55
commits into
main
Choose a base branch
from
refactor-to-typescript
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
ab73f01
feat: begin refactoring to TypeScript
kweeuhree f9b3aae
feat: add ListPath type
kweeuhree cf7ad59
feat: add types to all firebase functions
kweeuhree def133a
fix: change useAuth.jsx component extention to .tsx
kweeuhree 872d8fc
each User type property can be a string and null;add types to useAuth
kweeuhree 2082dee
fix: fix the way useShoppingLists takes props
kweeuhree c2f3988
fix: remove User type
kweeuhree 77945a8
fix: remove redundant User type; use DocumentData type where needed
kweeuhree 2e72f6a
add type to ManageList props
kweeuhree e48619d
fix: fix type of addItem function parameters
kweeuhree 8d648a2
feat: add types to AddItems component; pass label prop to TextInputEl…
kweeuhree 56736ac
feat: add types to TextInputElement component props, as well as patte…
kweeuhree 172a520
feat: add type to List component props, pass items to AddItems component
kweeuhree cb2b2a9
feat: add types to normalizeItemName utility function
kweeuhree 568b943
feat: add types to App component
kweeuhree 7c2a158
fix: add fixes to AddItems component types
kweeuhree 90bc64d
feat: add types to Home component
kweeuhree 84845a4
fix: add fixes to ManageList component type
kweeuhree 3ad80a5
fix: add fixes to List component type
kweeuhree 95c0608
feat: add types to Layout component
kweeuhree c0d64d4
feat: add types to useStateWithStorage hook
kweeuhree 1af02b2
fix: change main point of entry from jsx to tsx
kweeuhree 4312d46
feat: add types to ListItem component
kweeuhree 4b00780
feat: add types to RadioInputElement component
kweeuhree 5f0a39d
feat: add types to SingleList component
kweeuhree 9705ebd
feat: add types to ShareList component
kweeuhree 69d3615
feat: add types to dates.js module
kweeuhree 330b2d6
fix: adjust how parameters are being passed into functions
kweeuhree 5fceeb1
fix: remove redundant file
kweeuhree 26de591
fix: update listPath type to be either string or null
kweeuhree 1a75fda
fix: add optional chaining operator to items List component
kweeuhree 764ba25
fix[test]: update List component to take items prop
kweeuhree 67e1b92
troubleshoot AddItems component
kweeuhree cc87268
troubleshoot listPath in Home, List and AddItems components
kweeuhree d57923a
fix: fixed listPath issue with passing listPath as a prop from App to…
kweeuhree 8c395f0
fix: add listPath prop to List.test
kweeuhree 4117b8e
fix: userId and userEmail can be undefined; update functions to retur…
kweeuhree 640dae8
fix: add a try/catch block in index.ts to handle a case where root el…
kweeuhree 1ae6c7a
fix: handle a case where listPath is null
kweeuhree ba9cc89
fix: resolved merge conflicts relevant to changes made in components …
kweeuhree ae9a2c8
feat: update firebase.ts:
kweeuhree 705aee5
fix: use DocumentData type instead of custom User type
kweeuhree cbde328
fix: ensure that initialValue of useStateWithStorage hook cannot be n…
kweeuhree 14f2c0c
fix: ensure type safety
kweeuhree b89e7ce
feat: remove Props type and add types inside the functions declaratio…
kweeuhree cd979cd
fix: instead of typing out every NavLink, map over navLinkOptions to …
kweeuhree edf3f70
feat: add exports to index.ts to keep imports shorter
kweeuhree b3a3335
fix: remove redundant JSDocs
kweeuhree 21e73b2
fix: update imports props typing
kweeuhree c98404c
feat: abstract normalizing logic into normalize.ts and add listPath t…
kweeuhree 6475150
fix: update the way props are typed to support intellisense hovers
kweeuhree 8454367
fix: update imports and replace initial value from null to a string
kweeuhree 5ec39f7
feat: add navigate to Home in case listPath is null
kweeuhree 0400b4c
fix: add MemoryRouter to support useNavigate
kweeuhree b166e98
merge main branch
kweeuhree File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this might simplify a little bit