Propose get days from date functions #51
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code adds a function
getDateLastPurchasedOrDateCreated
that takes in two Timestamps: dateLastPurchased and dateCreated. The function will check whether dateLastPurchased can be converted to a date, and if not it will return a valid date that the item was created.Why adding:
The name is hefty, so I appreciate any input here!
This code also proposes a
getDaysFromDate
function, that takes in a valid JS date and returns the amount of days that passed from that date until today.Why adding:
Related Issue
Related to issue 13
Type of Changes
enhancement
Updates
Testing Steps / QA Criteria
Ensured that
calculateDateNextPurchased
still works with the new abstraction