Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverted sign-in button additions #17

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Reverted sign-in button additions #17

merged 2 commits into from
Aug 11, 2024

Conversation

tannaurus
Copy link
Collaborator

@tannaurus tannaurus commented Aug 11, 2024 •
edited
Loading

Description

  1. The first commit makes a change out of scope for the goal of this PR but necessary to commit the desired changes: changing the footer's anchor tags to be buttons instead. Without this change, the pre-commit hook would fail
image
  1. Reverted changes for issue 1. As a user, I want to be able to sign in to the app. #1

@tannaurus tannaurus changed the title Tg/remove signin button Reverted sign-in button additions Aug 11, 2024
@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit 2f957a1):

https://tcl-77-smart-shopping-list--pr17-tg-remove-signin-but-rt102h1f.web.app

(expires Sun, 18 Aug 2024 16:01:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72

@tannaurus tannaurus merged commit e0cb928 into main Aug 11, 2024
3 checks passed
@adidalal adidalal deleted the tg/remove-signin-button branch August 11, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tannaurus