-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting item off the list #29
Conversation
Visit the preview URL for this PR (updated for commit e21a512): https://tcl-79-smart-shopping-list--pr29-hm-mm-deleteitem-dwihflzw.web.app (expires Mon, 23 Sep 2024 13:18:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d91d9ddbda780208241c52942f544acf8e81407a |
… delete button are individually more visible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Well done guys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is one issue, when I type the number item name in the field, it accepts it and when I go to my list it displays only the button.
@Hudamabkhoot @marshjaja
Description
Users can now delete list items to help them keep their lists tidy by clicking the delete button next to the items on their lists. Users will be shown a prompt to confirm or cancel the item deletion upon clicking that button.
Related Issue
closes #12
Acceptance Criteria
ListItem
component renders a button that allows the user to delete an item from their list when clickeddeleteItem
function inapi/firebase.js
has been filled out, and deletes the item from the Firestore databaseType of Changes
Feature
Updates
Before
After
Testing Steps / QA Criteria
git pull
andgit checkout hm-mm-deleteItem
.npm start
.List
page and you'll find a delete button next to each item.deletion canceled
message will be displayed.