Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading state bug fix and minor style adjustments #57

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

Hudamabkhoot
Copy link
Collaborator

Description

  • Moved the laoding state to useShoppingListData to fix the loading spinner issue now it only shows if data are being fetched.
  • Fixed the flashing list items in empty lists before it shows Your list is empty. by waiting for the path to be set before navigating.
  • Added a button to navigate back to home when No list selected shows in list page.
  • Adjusted the spacing between filter and create list inputs and their labels, added an icon in the create list input to match the filter one and added a placeholder text to it.

Type of Changes

bug fix, enhancement,

Updates

Before

Screen Shot 2024-10-18 at 2 16 45 PM

After

Screen Shot 2024-10-18 at 2 17 02 PM
Screen Shot 2024-10-18 at 2 17 29 PM

Testing Steps / QA Criteria

  • Do a git pull and git checkout hm-loading-bug-fix
  • Open the homepage by running npm start.
  • Navigate to the list page.
  • The loading spinner now wont show when adding and editing items.

Copy link

github-actions bot commented Oct 18, 2024

Visit the preview URL for this PR (updated for commit 32e36d7):

https://tcl-79-smart-shopping-list--pr57-hm-loading-bug-fix-amk4oc7p.web.app

(expires Fri, 25 Oct 2024 12:04:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d91d9ddbda780208241c52942f544acf8e81407a

@Hudamabkhoot Hudamabkhoot merged commit fdbed55 into main Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant