-
Notifications
You must be signed in to change notification settings - Fork 60
Remove Old Icon Format #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the old icon format configurations from the iOS/macOS app by deleting the Contents.json files for both OraIcon and OraIconDev app icon sets. The change is based on the assumption that the new iOS 26 icon format provides backwards compatibility with previous OS versions.
- Deletion of legacy icon configuration files
- Removal of multiple icon size specifications for both production and development icon sets
Reviewed Changes
Copilot reviewed 2 out of 22 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ora/Assets.xcassets/OraIcon.appiconset/Contents.json | Removes production app icon configuration with multiple size variants |
| ora/Assets.xcassets/OraIconDev.appiconset/Contents.json | Removes development app icon configuration with multiple size variants |
Comments suppressed due to low confidence (2)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
not working on macos 15 @Aeastr |
|
@yonaries is this just ran straight from xcode? sometimes the new format requires the app bundle to be built for release (archived) for it to build the icon |
|
yes, just running from Xcode. does that mean the new icons format doesn't support macOS 15? |
|
i'm pretty sure it only works on app export, not running from Xcode, it's even like that on macOS 26 i can show it working with export |
|
I use the previous .appiconset in #116, glad to adapt for Icon Composer icons. And I tried to recreate the dark mode icon, but I do not know the slogan font and other details, would you mind share the Sketch/Figma source file so I can get the slogan layer?
|
|
@yonaries The new icon format appears to only function correctly in archived/exported builds, not during Xcode development runs - even on macOS 26. We need someone to verify backward compatibility on pre-macOS 26 by testing an actual exported build rather than just running from Xcode |
|
@shindgewongxj the icons are already icon composer files under the icons folder |
|
I built from this branch which seems to be on v0.2.2 |
|
The build from |
Let me know if the icon from this build is working properly on macOs 26 |
|
Build from |
|
i think there's also an issue with
0.2.3 pictured on the left vs my build, it's not using the .icon version and falls back to the old format, meaning dark mode and other modes (clear, tinted, etc) don't work |
|
can probably open an issue for this, im not sure what is going wrong, can share what i had to do on my end to get the new one to show up |
Maybe an issue with xcodegen? |








The new 'OS 26 .icon format is backwards compatible with previous OS versions, so the old format should not be needed.
Would need someone to verify on a pre-26 device to be sure, but general findings show it works