Skip to content

Conversation

@Aeastr
Copy link
Collaborator

@Aeastr Aeastr commented Sep 17, 2025

The new 'OS 26 .icon format is backwards compatible with previous OS versions, so the old format should not be needed.

Would need someone to verify on a pre-26 device to be sure, but general findings show it works

Copilot AI review requested due to automatic review settings September 17, 2025 22:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the old icon format configurations from the iOS/macOS app by deleting the Contents.json files for both OraIcon and OraIconDev app icon sets. The change is based on the assumption that the new iOS 26 icon format provides backwards compatibility with previous OS versions.

  • Deletion of legacy icon configuration files
  • Removal of multiple icon size specifications for both production and development icon sets

Reviewed Changes

Copilot reviewed 2 out of 22 changed files in this pull request and generated no comments.

File Description
ora/Assets.xcassets/OraIcon.appiconset/Contents.json Removes production app icon configuration with multiple size variants
ora/Assets.xcassets/OraIconDev.appiconset/Contents.json Removes development app icon configuration with multiple size variants
Comments suppressed due to low confidence (2)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yonaries
Copy link
Contributor

image

not working on macos 15 @Aeastr

@Aeastr
Copy link
Collaborator Author

Aeastr commented Sep 19, 2025

@yonaries is this just ran straight from xcode? sometimes the new format requires the app bundle to be built for release (archived) for it to build the icon

@yonaries
Copy link
Contributor

yes, just running from Xcode.

does that mean the new icons format doesn't support macOS 15?

@Aeastr
Copy link
Collaborator Author

Aeastr commented Sep 20, 2025

i'm pretty sure it only works on app export, not running from Xcode, it's even like that on macOS 26

i can show it working with export

@shindgewongxj
Copy link
Contributor

I use the previous .appiconset in #116, glad to adapt for Icon Composer icons. And I tried to recreate the dark mode icon, but I do not know the slogan font and other details, would you mind share the Sketch/Figma source file so I can get the slogan layer?

image

@Aeastr
Copy link
Collaborator Author

Aeastr commented Sep 22, 2025

@yonaries The new icon format appears to only function correctly in archived/exported builds, not during Xcode development runs - even on macOS 26. We need someone to verify backward compatibility on pre-macOS 26 by testing an actual exported build rather than just running from Xcode

@Aeastr
Copy link
Collaborator Author

Aeastr commented Sep 22, 2025

@shindgewongxj the icons are already icon composer files under the icons folder

@Aeastr
Copy link
Collaborator Author

Aeastr commented Sep 22, 2025

the confusing with .icon is, when you run from xcode you get this
CleanShot 2025-09-22 at 01 13 10@2x

but, if you build for release, it works (Xcode 26)
CleanShot 2025-09-22 at 01 13 36@2x

@kenenisa
Copy link
Contributor

the confusing with .icon is, when you run from xcode you get this CleanShot 2025-09-22 at 01 13 10@2x

but, if you build for release, it works (Xcode 26) CleanShot 2025-09-22 at 01 13 36@2x

So i'm using Xcode26 but still on macOs 15.6. The xcode build works as expected but on the build the icon is not showing up. Seems to be the reverse here.
image
Left: Xcode26 build Right: build running on macOs15.6 (built using the build script)

@kenenisa
Copy link
Contributor

I built from this branch which seems to be on v0.2.2

@kenenisa
Copy link
Contributor

The build from main is working as expected
Ora-Browser-0.2.3.dmg.zip

@kenenisa
Copy link
Contributor

The build from main is working as expected Ora-Browser-0.2.3.dmg.zip

Let me know if the icon from this build is working properly on macOs 26

@kenenisa
Copy link
Contributor

Build from fix/redundant-icons:
Ora-Browser-0.2.2.dmg.zip

@Aeastr
Copy link
Collaborator Author

Aeastr commented Sep 26, 2025

i think there's also an issue with

The build from main is working as expected Ora-Browser-0.2.3.dmg.zip

Let me know if the icon from this build is working properly on macOs 26

CleanShot 2025-09-26 at 17 09 55@2x

0.2.3 pictured on the left vs my build, it's not using the .icon version and falls back to the old format, meaning dark mode and other modes (clear, tinted, etc) don't work

@Aeastr
Copy link
Collaborator Author

Aeastr commented Sep 26, 2025

can probably open an issue for this, im not sure what is going wrong, can share what i had to do on my end to get the new one to show up

@kenenisa
Copy link
Contributor

kenenisa commented Sep 26, 2025

can probably open an issue for this, im not sure what is going wrong, can share what i had to do on my end to get the new one to show up

Maybe an issue with xcodegen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants