Hide favorited/pinned tabs placeholder after use #159
+111
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
thanks. will check it. |
yonaries
requested changes
Oct 29, 2025
Contributor
|
can we introduce close all tabs button here? to close all normal tabs |
Author
|
Sure, I'll add in a quick thing for that |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a feature to hide the placeholder UI for favorited and pinned tabs after they've been used for the first time. It adds persistent state management using AppStorage to track whether placeholders should remain "sticky" (always visible) or hidden after use. Additionally, it introduces a "Clear" button that appears on hover to remove all normal tabs from a container.
Key changes:
- Added
stickyFavsandstickyPinnedboolean flags inSidebarManagerto control placeholder visibility - Enhanced
SectionDropDelegatewith hover state tracking to show placeholders during drag operations - Implemented a hover-activated "Clear" button for removing all normal tabs
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ora/Services/SidebarManager.swift | Added AppStorage properties to track sticky state for favorites and pinned tabs placeholders |
| ora/Services/SectionDropDelegate.swift | Added isHovering binding and custom initializer to support hover state during drag operations |
| ora/Modules/Sidebar/TabList/PinnedTabsList.swift | Implemented conditional placeholder rendering based on sticky state and hover, with onChange handler to disable sticky mode |
| ora/Modules/Sidebar/TabList/FavTabsList.swift | Similar conditional placeholder logic for favorites section with hover-aware empty state |
| ora/Modules/Sidebar/SidebarView.swift | Reduced VStack spacing from 16 to 0 for tighter layout |
| ora/Modules/Sidebar/ContainerView.swift | Added "Clear" button UI with hover detection to remove all normal tabs from a container |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this tweet https://x.com/enrico_milli/status/1981473807371288872, closes #158, adds "Clear" button for normal tabs.