feat: implement color theme selection and notification system #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: open link suggestion for url with paths * refactor: add import data menu and update style for link preview
- Move all build artifacts, including appcast.xml and DSA keys, to a dedicated build/ directory for better organization. - Update build-release.sh and create-release.sh scripts to reference new paths for signing and exporting. - Remove deprecated appcast.xml and DSA key files from the root directory. - Enhance README and documentation to reflect changes in file structure and hosting setup.
…ppcast updates - Update .gitignore to include critical DSA key files and prevent accidental commits. - Modify build-release.sh to preserve DSA keys and appcast during clean builds. - Revise create-release.sh to ensure proper signing of the DMG and update appcast.xml with the correct signature and file size. - Improve setup scripts and documentation for Sparkle tools installation and DSA key generation. - Ensure security checks are in place to prevent committing sensitive keys.
…matic DMG upload and Xcode project regeneration
- Add auto-version increment in create-release.sh when no version specified - Fix signature validation with proper error handling and fail-fast on failures - Enhance UpdateService with comprehensive logging and timeout handling - Improve GeneralSettingsView with detailed update status and version display - Update documentation to reference correct repository URLs - Add appcast.xml backup for version tracking
…release.sh to use version from project.yml. This ensures consistent naming and improves clarity in release process.
…in project.yml.bak
* chore: readme fix * chore: buy me coffee added
* chore: add keyboard shortcut URL bar focus * feat: add escape key support to exit URL bar editing mode * Remove redundant editingURLString assignments
* add ColorTheme enum with light and dark variants * integrate color theme into Theme struct * update ThemeProvider to handle color theme changes * add color scheme selector in GeneralSettingsView * persist color theme selection in UserDefaults
* consolidate modelContext calls in OraApp * improve theme transition animation in ThemeProvider * remove redundant theme loading logic
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive color theme selection system with notification-based updates, allowing users to choose from 8 different color schemes (Orange, Blue, Green, Purple, Red, Teal, Pink, Gray) that persist across app restarts.
- Adds ColorTheme enum with 8 color variants and corresponding light/dark colors
- Integrates color theme into the Theme struct and updates ThemeProvider with notification handling
- Adds a visual color scheme selector in GeneralSettingsView with animated selection
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ora/oraApp.swift | Reorders modelContext calls before environmentObject calls |
| ora/Services/AppearanceManager.swift | Adds colorTheme property with UserDefaults persistence and notification posting |
| ora/Modules/Settings/Sections/GeneralSettingsView.swift | Implements visual color scheme selector with grid layout and gradient previews |
| ora/Common/Constants/Theme.swift | Defines ColorTheme enum, updates Theme struct, and adds notification-based ThemeProvider |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* add ThemeConstants struct for color transition duration and user defaults key * update ThemeProvider and GeneralSettingsView to use ThemeConstants * ensure consistent theme loading and animation duration across components
kenenisa
requested changes
Sep 7, 2025
Contributor
kenenisa
left a comment
kenenisa
left a comment
There was a problem hiding this comment.
This is really nice. It’d be nice if we can support more colors/selections maybe the way arc does it. Also it’d be nice if you can enhance the color scheme slection experience.
Author
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
video here