Fix: Folder name syntax error on Windows due to invalid characters #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
🌟 Superstar Contributor Alert! Huge thanks again to @LeonardoLBraga for another solid contribution! This update handles cases where files might contain characters that cause issues on Windows — something I hadn’t even tested for yet. I’ve done much of this on Pythonista on my lunch breaks (hence they 80 commits to a readme when I can only use GitHub haha) This is exactly what this project is about: real-world improvements, thoughtful collaboration, and learning as we go. Thank you for this - truly. You’re making PySorta stronger one PR at a time. — theProject. |
Owner
|
Once again - clean pass! Merging! |
Owner
|
Whoops - I closed before I merged, reopened - I’m learning too! See that hahah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue on Windows where folder creation would fail when organizing by file size, due to the use of invalid characters (
<,>) in folder names.What was changed?
The folder names were updated to use valid characters:
"Small (<1MB)"→"Small (under 1MB)""Medium (1–10MB)"→"Medium (1-10MB)""Large (>10MB)"→"Large (over 10MB)"Why is this fix necessary?
Windows does not allow characters like
<and>in folder or file names. This was causing anOSError: [WinError 123].Related Issue
Closes #5